Skip to content

0.29 Backports#93

Draft
microstudi wants to merge 90 commits intorelease/0.29-stablefrom
0.29-backports
Draft

0.29 Backports#93
microstudi wants to merge 90 commits intorelease/0.29-stablefrom
0.29-backports

Conversation

…dim#13221)

* remove share_tokens from admin/components/_form

* add routes

* add component name on index title

* add form and new views

* fix index styles

* refactor share_token form

* refactor share_token form

* add locales keys

* add automatic_token attribute

* refactor createsharetoken command

* remove target_blank

* add more methods to sharetokenform

* refactor token_for definition

* add edit and update method to controller

* fix routing error

* add create and update command specs

* fix spelling error

* fix spelling error

* add share_token_form spec

* remove target_ blank from edit action

* remove set_default_expiration method

* add collection_radio_buttonts

* fix no expitration bug

* add registered_only to decidim_share_tokens migration

* add more checks to share_tokens_form spec

* add more checks to commands create and update share_token spec

* add copy clipboard functionality

* fix lint errors

* add is_active_link for share_tokens_path

* remove space detected

* fix noMethodError on user_can_preview_component? method

* add enforce_permission to controller

* fix manage_components_share_tokens spec

* fix manage_process_components_examples spec

* fix share_token_spec

* add share_tokens routes on initiatives-module

* remove unused i18n keys

* add more checks to manage_component_share_tokens

* fix has to edit a share token case check

* add spec check allows copying the share link from the share token

* save clipboard-copy-label-original

* fix clipboard js

* fix validations and views

* add specs

* update permissions

* update documentation

* add help text

* allow to manage participatory spaces share tokens

* add space specs

* add preview specs

* fix clipboard

* fix specs

* fix new minimum page items

* trailing spaces

* use standard datepicker

* fix surveys component actions

* make spec deterministic

* fix specs

* debug

* prevent token repetition in parallel tests

* apply corrections

* fix typo

* fix typo

* harmonize copies

* apply review

* lint

* change test

* apply review

* add td sizes

* normalize sizes

* add action logs

* add model specs

* fix title interpolation

* fix creat command spec

---------

Co-authored-by: elviabth <ejbenedith@gmail.com>
@microstudi microstudi changed the title Improve components and spaces sharing with administrable tokens (#13221) 0.29 Backports Jun 3, 2025
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

microstudi and others added 27 commits June 3, 2025 14:14
* remove nested

* add reload

* debug

* manually set tokens

* add sleep

* cleanup
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* update validations, add pending_location_text

* add tests

* update notifications

* add tests

* refactor: move pending_location? logic to model

* Apply suggestions from code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* fix test

* fix validations

* change validations

* fix validations

* change tests

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
…sals" is unchecked (decidim#15050)

Co-authored-by: andra-panaite <135139066+andra-panaite@users.noreply.github.com>
Co-authored-by: Tom Greenwood <101816158+greenwoodt@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Alexander Rusa <alex@rusa.at>
Co-authored-by: stephanierousset <61418966+Stef-Rousset@users.noreply.github.com>
… mouse' to v0.29 (decidim#15095)

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
…ecidim#15099)

Co-authored-by: Alejandro Puerta <71900287+apuertadelaguila@users.noreply.github.com>
…' to v0.29 (decidim#15098)

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: Tom Greenwood <101816158+greenwoodt@users.noreply.github.com>
Co-authored-by: stephanierousset <61418966+Stef-Rousset@users.noreply.github.com>
Co-authored-by: stephanierousset <61418966+Stef-Rousset@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
alecslupu and others added 20 commits October 17, 2025 16:35
…#15368) (decidim#15391)

Co-authored-by: Alejandro Puerta <71900287+apuertadelaguila@users.noreply.github.com>
…5386)

Co-authored-by: ’Barbara Oliveira <143180473+BarbaraOliveira13@users.noreply.github.com>
Co-authored-by: Tom Greenwood <101816158+greenwoodt@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Masayoshi Takahashi <takahashim@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Ivan Vergés <ivan@pokecode.net>
Co-authored-by: stephanierousset <61418966+Stef-Rousset@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…m#15544)

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* New translations en.yml (Romanian)

* New translations en.yml (Spanish)

* New translations en.yml (Arabic)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (German)

* New translations en.yml (Greek)

* New translations en.yml (Basque)

* New translations en.yml (Hungarian)

* New translations en.yml (Italian)

* New translations en.yml (Lithuanian)

* New translations en.yml (Dutch)

* New translations en.yml (Norwegian)

* New translations en.yml (Polish)

* New translations en.yml (Portuguese)

* New translations en.yml (Slovak)

* New translations en.yml (Swedish)

* New translations en.yml (Turkish)

* New translations en.yml (Chinese Simplified)

* New translations en.yml (Chinese Traditional)

* New translations en.yml (Galician)

* New translations en.yml (Icelandic)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Indonesian)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Latvian)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Ukrainian with many plural form)

* New translations en.yml (Russian with many plural form)

* New translations en.yml (Catalan, Algherese)

* New translations en.yml (Finnish)

* New translations en.yml (Romanian)

* New translations en.yml (Basque)

* New translations en.yml (Basque)

* New translations en.yml (Italian)

* New translations en.yml (Swedish)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Catalan, Algherese)

* New translations en.yml (Basque)

* New translations en.yml (Turkish)

* New translations en.yml (Turkish)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Basque)

* New translations en.yml (Basque)

* New translations en.yml (Turkish)

* New translations en.yml (Basque)

* New translations en.yml (Italian)

* New translations en.yml (Italian)

* New translations en.yml (Basque)

* New translations en.yml (Italian)

* New translations en.yml (Italian)

* New translations en.yml (Italian)

* New translations en.yml (Turkish)

* New translations en.yml (Basque)

* New translations en.yml (Korean)

* New translations en.yml (Vietnamese)

* New translations en.yml (Persian)

* New translations en.yml (Maltese)
* Added vote on proposals listing page

* Run linter

* Fixed tests

* Run linter

* Refactor for proposal cards vote button

* Changed markup

* Updated test file to current markup

* add styling for listing and grid view

* Added class on progress-bar container

* styling for grid and listing with and without progress bar

* code refactor and small styling fixes

* change layout for votes on proposals with votes limit

* Added class when votes counter is hidden

* design changes for votes hidden

* css fixes

* Run linter

* Fixed test

* Refactoring code

* Run prettier

* changes after review

* Final fixes

* Fix proposals

* Fix failing specs

* Add specs

* Finish specs

* Refactor css

* Refactor js selector

* Run linters

* Refactor remaining votes counter to data attribute

---------

Co-authored-by: andra-panaite <andra.panaite@tremend.com>
Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 330d9be8-b204-434e-a3e4-a3784ba3f594

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 0.29-backports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

{
title: "A reasonable proposal title",
body: "A reasonable proposal body",
address: "Carrer de Balmes, 132, Barcelona",

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error test

Balmes is not a recognized word. (unrecognized-spelling)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants